Fireplaces are warm, books are burnable, burn papers with fireplaces #32087
+144
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Needs Review
|
it takes forever for the fireplace to actually warm a large area up (which is fine), that's why I'm in a two tile room for testing |
|
finally, bloodred scare in ss14... |
|
test fail is real and related to the appearance component on the books, I'll deal with it later |
|
bonfire teg real |
oh shit you just made me realize I forgot to log a change |
slarticodefast
added
the
Status: Awaiting Changes
|
does fireplace put you on fire? can you cook on fireplace like on a grill? |
No, it just works as if it's a lit welder or lighter. Interacting with it doesn't light yourself on fire either in my testing. Not sure about the cooking. |
github-actions
bot
removed
the
Status: Awaiting Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fireplaces and bonfires will now passively heat the air around them to 305K (31.5C). Feeling cold? Come stop by the library.
Fireplaces and bonfires are now treated as constantly ignited ignition sources. Plasma leak in the library? Oh... unfortunate.
Books are now burnable in the same way that paper is. This does not apply to guidebooks.
Flammable objects now have an AfterInteract event. When using a flammable object on something else that is hot, like a lighter or fireplace, it will now ignite.
Previously, you were only capable of lighting something by using the lit object on the paper. This didn't work with fireplaces, because you don't hold a fireplace in your hand. So this behavior was added to work in reverse. Clicking on a fireplace does not ignite yourself with this added behavior.
Why / Balance
I want my fireplace to warm me up. I want to roleplay burning my books in my fireplace for warmth when I'm dying of cold.
Technical details
Added the RadiantTemperatureComponent/System. This will actively heat or cool down the air on the tile the entity is until it reaches the specified goal temperature. Whether it heats or cools is determined by the set rate of change.
Bonfires and fireplaces use the RadiantTemperature component and heat air to a comfortable 305K (heat damage is taken at 325K).
FlammableSystem's AfterInteractEvent is more or less just the copy/paste of what happens when you use the lit object on the flammable one, but in reverse with the targets.
Books more or less received a copy and paste of whatever made paper flammable.
Media
2024-09-11.13-14-52.mp4
2024-09-11.21-22-56.mp4
Atmos Device Update
2024-09-16.23-37-53.mp4
Requirements
Breaking changes
Changelog
🆑